r2650 - in trunk: libmcrypto libmikey libminisip libmnetutil libmsip libmstun libmutil libmutil/m4 milbc minisip minisip/minisip/gui/gtkgui ministun

[Zach Welch]

mikma at minisip.org wrote:
> Author: mikma
> Date: 2006-06-09 18:29:59 +0200 (Fri, 09 Jun 2006)
> New Revision: 2650
> 
> Modified:
>    trunk/libmcrypto/configure.ac
>    trunk/libmikey/configure.ac
>    trunk/libminisip/configure.ac
>    trunk/libmnetutil/configure.ac
>    trunk/libmsip/configure.ac
>    trunk/libmstun/configure.ac
>    trunk/libmutil/configure.ac
>    trunk/libmutil/m4/libmutil.m4
>    trunk/milbc/configure.ac
>    trunk/minisip/configure.ac
>    trunk/minisip/minisip/gui/gtkgui/MainWindow.cxx
>    trunk/ministun/configure.ac
[snip]

If it matters, one reason for the refactoring that I did into
libmutil.m4 was to prevent the need for this kind of global change.

Instead of adding the AM_MINISIP_PACKAGE_UNRELEASED to every
configure.ac file, you could have simply added the call to it from
within an existing macro; in each case, your new call follows after
AM_MINISIP_PACKAGE_INIT. That would have been a logical place to put the
call, making its "removal" easier to accomplish. With other changes, a
release could be made without having to actually remove the macro.

Please consider regressing these configure.ac changes and adding the
internal call; otherwise, I love what you've done with this patch.

Cheers,

Zach