r2752 - trunk/libmsip/source/dialogs

[Mikael Magnusson]

Erik Eliasson wrote:
> On Sun, 2006-09-10 at 15:17 +0200, Mikael Magnusson wrote:
> 
> 
>>I think this breaks PRACK support in the client, since -1 is used as a 
>>special value by SipDialogVoipClient.cxx. (You could try to change it to 
>>"(uint32_t)-1").
>>
> 
> 
> Making the variable a int32_t instead of uint32_t should be ok, right?
> (RFC3262 limits the rseq value to 2^31-1).
> 
> Sorry,
> Erik
> 

According to RFC3262 the initial RSeq can be exactly 2^31-2, and that 
means the third reliable provisional respons can have RSeq = 2^31 (not 
counting retransmissions), which can't be represented using int32_t.

    RSeq
    numbers MUST NOT wrap around.  Because the initial one is chosen to
    be less than 2**31 - 1, but the maximum is 2**32 - 1, there can be up
    to 2**31 reliable provisional responses per request, which is more
    than sufficient.

Mikael