r3431 - trunk/libminisip/source/subsystem_media

erik at minisip.org erik at minisip.org
Tue Oct 16 23:08:42 CEST 2007


Author: erik
Date: 2007-10-16 23:08:42 +0200 (Tue, 16 Oct 2007)
New Revision: 3431

Modified:
   trunk/libminisip/source/subsystem_media/Session.cxx
Log:
 * libminisip/media:
    You got a warning when printing media debug output when having 
    a session without call recorder.

  Replaced:
    MRef<CallRecorder *> cr = dynamic_cast<CallRecorder *>(*callRecorder);
    if( cr ) {
        ...
  with:
    if( callRecorder ) {
        MRef<CallRecorder *> cr = dynamic_cast<CallRecorder *>(*callRecorder);
        ...
  In the first case, MRef prints a warning when dereferencing the NULL reference.



Modified: trunk/libminisip/source/subsystem_media/Session.cxx
===================================================================
--- trunk/libminisip/source/subsystem_media/Session.cxx	2007-09-20 08:11:18 UTC (rev 3430)
+++ trunk/libminisip/source/subsystem_media/Session.cxx	2007-10-16 21:08:42 UTC (rev 3431)
@@ -1061,20 +1061,19 @@
 	else 
 		ret += "; silencedSources = false";	
 
-	MRef<CallRecorder *> cr = dynamic_cast<CallRecorder *>(*callRecorder);
-	if( cr ) {
+	if( callRecorder ) {
+		MRef<CallRecorder *> cr = dynamic_cast<CallRecorder *>(*callRecorder);
 		ret += "\n          ";
 		cr = dynamic_cast<CallRecorder *>( *callRecorder );
 		ret += "; " + cr->getDebugString();
-	}
-	
+	}	
 	for( std::list< MRef<MediaStreamReceiver *> >::iterator it = mediaStreamReceivers.begin();
 				it != mediaStreamReceivers.end(); it++ ) {
-		ret += "\n" + (*it)->getDebugString();
+		ret += "\n          " + (*it)->getDebugString();
 	}
 	for( std::list< MRef<MediaStreamSender *> >::iterator it2 =  mediaStreamSenders.begin();
 				it2 !=  mediaStreamSenders.end(); it2++ ) {
-		ret += "\n" + (*it2)->getDebugString();
+		ret += "\n          " + (*it2)->getDebugString();
 	}
 	return ret;
 }



More information about the Minisip-devel mailing list