r3415 - trunk/libminisip/source/subsystem_signaling/sip

erik at minisip.org erik at minisip.org
Tue Sep 4 20:23:33 CEST 2007


Author: erik
Date: 2007-09-04 20:23:32 +0200 (Tue, 04 Sep 2007)
New Revision: 3415

Modified:
   trunk/libminisip/source/subsystem_signaling/sip/SipDialogVoipServer.cxx
Log:

 * Bug fix, libminisip: This fixes a bug introduced not so long ago.
   A PRACK transition executed when it should not (for example when the
   dialog layer received a transport error).



Modified: trunk/libminisip/source/subsystem_signaling/sip/SipDialogVoipServer.cxx
===================================================================
--- trunk/libminisip/source/subsystem_signaling/sip/SipDialogVoipServer.cxx	2007-08-31 09:35:45 UTC (rev 3414)
+++ trunk/libminisip/source/subsystem_signaling/sip/SipDialogVoipServer.cxx	2007-09-04 18:23:32 UTC (rev 3415)
@@ -440,12 +440,12 @@
 }
 
 bool SipDialogVoipServer::a3008_100rel_ringing_PRACK( const SipSMCommand &command){
-	if( use100Rel &&
-	    lastProvisional &&
-	    !transitionMatch("PRACK", 
+	if( ! (use100Rel &&
+	       lastProvisional &&
+	       transitionMatch("PRACK", 
 			     command, 
 			     SipSMCommand::transaction_layer, 
-			     SipSMCommand::dialog_layer) ){
+			     SipSMCommand::dialog_layer) ) ){
 		return false;
 	}
 
@@ -509,11 +509,11 @@
 }
 
 bool SipDialogVoipServer::a3010_any_any_PRACK( const SipSMCommand &command){
-	if( use100Rel &&
-	    !transitionMatch("PRACK", 
+	if( ! (use100Rel &&
+	       transitionMatch("PRACK", 
 			     command, 
 			     SipSMCommand::transaction_layer, 
-			     SipSMCommand::dialog_layer) ){
+			     SipSMCommand::dialog_layer) ) ){
 		return false;
 	}
 		



More information about the Minisip-devel mailing list