minisip trunk build error

[Zach Welch]

Trimmed with replies in-line.

Cesc wrote:
> I repeat, for the last time. During the last few months, the only
> thing that changed is minisip ... libtool stayed the same. And minisip
> used to compile. Now it doesn't.

This does not surprise me; I made massive changes to the build system.
The changes give much more flexibility than we had; previously, we did
not have the ability to specify --with-* flags.

Incidentally, I know that those options are still not correctly
implemented. There is more work to do, but we need to fix problems with
the code before I can fully fix the build system. In this regard, the
biggest problems are the layering violations identified in my last post,
but I will revisit this in my follow up in the stun thread.

> And it is not just libtool ... i remind you. Even you work around the
> .libs/.libs problem, a whole bunch of other problems persist.

Can you be specific here?   If you meant libltdl, I want to hear that a
newer version of that package/debs does not fixes your problems. ;)

> 
>> Besides, this is a development tool; the built packages should still run
>> on Debian stable, even if you have to upgrade libtool to do it.
>>
> 
> I will try to contact the libtool mantainer for debian ...

Incidentally, there is another way to look at this; when is the next
scheduled 'stable' update bound to happen? When is our next release?
Try not to laugh; these questions are rhetorical. :)

> I do not blame you or your script. If that was the impression in the
> mail, i apologize.

Heh, I wasn't really looking for an apology; you didn't offend me or
anything. I just wanted to be absolutely clear where I think the real
problem exists; the problems that you see in minisip are symptoms.

> Now, what i do say is that with all the changes in the last few
> months, the compilation was broken. My fault is also there for not
> trying in an earlier stage and pointing out that compilation was
> broken. And, given you and mikael did most of the changes and seem to
> be the most literate in this area, i would request you take some time
> to fix it. I will put some time also, but i do not "control" so much
> the auto-tools stuff.

Well, I do not want to ignore your request, since you are contributing;
however, you definitely must fix it yourself. I do not run Debian and
can not test the solution, but I stand by my assertion that the fix is
to "simply" upgrade/patch your libtool package. ;)

> And if i may point out one inconsistency in the line of thought ...
> why the code style needs to stick to the 80 column rule (old
> fashioned, really out-of-date editors) when the state of the art is
> far ahead? ;)  Even debian stable has better editors :)

Vim 7.0 just came out. That will be state of the art for me, but 6.x
works fine for now. :) Besides, I am perfectly comfortable doing my
development with a ssh connection and a screen session; the box can be
on the other side of the world, and sometimes it is. In that case, it
can be very nice to use 'less' to view the code.

More pragmatically, I think the best reason to keep within 80 columns is
that it reflects one measure of engineering discipline. If you need to
indent that much (or can't be bothered to properly wrap or beautify your
code), you probably have problems with the design of your code. The
conceptual integrity, appearance, and minimalism of patches/commits are
similar measures of an individual's engineering abilities. These are
qualitative metrics that I use in my recommendation and hiring processes.

> in-tree + not install -> buildall.sh
> out-of tree such is done by build.pl is perfectly fine by me.
> I still don't see where does this come from ... i have no problem with
> the build.pl tool per se ... just with the broken compilation on a
> perfectly valid platform (the stable debian is simply one year old ...
> it is not like i am trying to compile on minix or something like
> that).

The Debian stable tree might be one year old, but the version of libtool
that you have (1.5.6) is just over two years old. Still, I agree it
would be nice to be able to support this particular feature.

Hey, just a thought, libtool can't be switched like autoconf/automake,
can it? That would make this thread so much hot air, it would be funny.

Cheers,

Zach